On Apr 22, 11:40 pm, Minh Nguyen <nguyenmi...@gmail.com> wrote:
> Hi Michael,
Hi Minh,
> My policy thus far is to list the author(s) of the patch(es). The case
> you mentioned above was a result of me misreading ticket #5146. This
> is because for the patch variety_patch.3.patch, I saw the description
> "Updated with some of Martin's comments" so I assumed that Martin had
> some direct input. I tried to be generous in attributing credit.
Well, if someone posts a 3 kb reviewer patch for a 250kb patch (#5180
for example) I tend to give a person reviewer credit. In fact,
anything marked as reviewer patch should not get author credit. Often
enough someone fixes a tiny issue in a patch and just posts the
changed original patch of the author - this happens quite often when
people use queues. I would prefer if the notes I post for each alpha
and rc would match the credit mentioned in the release tour. That way
it is easy enough for someone to complain if they shouldn't or didn't
get credit and the two different documents would be in sync, i.e. you
see on list when I fix things and you should let me know if anyone
complained about the release tour. Because I took a look at the
changes by David Loeffler I gave Chris Kurth partial author credit for
#5180.
If you also used the author/reviewer system as I do in the release
notes no confusion should arise and you mention all people getting
credit on the ticket :)
Thoughts?
> --
> Regards
> Minh Van Nguyen
Cheers,
Michael
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
