>> - if os.access (filename, os.X_OK): >> + if os.access (filename, os.X_OK) and not os.path.isdir(f): >> return filename > > Ok, I see the problem now. Sorry for being dense earlier. In Sage that
No problem. > codepath clearly doesn't seem to be hit. Yes, clearly that codepath was never tested. It's weird that I am hitting it while in Sage one is not, and that most likely leads to some bug that I introduced in my other modifications. >> Hopefully this makes it clear, that this is a bug, no matter what >> other packages I modified. Or do you disagree? If so, what is the >> purpose of introducing the undefined variable "f" then? > > It is a bug, without looking at the context: Does removing the first > hunk fix the problem for you? I am not sure why the hunk was added, it > has been a while since I did that review ;) I just applied the patch that changed f->filename, see my previous emails. Ondrej --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
