Given your time constraints and the problems you mentioned, what I would do is the following (though possibly Michael might recommend something else):
(a) apply to a clone of the most recent version of Sage the changes you want (including those of M Hansen) "manually", (b) create a new "big" patch and attach it to 4036. (this is the rebase). Test this on as many platforms as you can. (c) Mention as a trac comment what you just said (you give everything a positive review, but you added some material ...), then replace "needs rebase" by "positive review, needs further review". (I can't find the "legal" strings for trac tickets on http://wiki.sagemath.org/TracGuidelines, but it's something like this.) (d) Email someone to ask for an immediate quick review. I can try myself or maybe Martin Rubey or Simon King can? On Sat, Jan 17, 2009 at 1:15 PM, Bill Page <bill.p...@newsynthesis.org> wrote: > > David, > > http://trac.sagemath.org/sage_trac/ticket/4036 > > Does not apply cleanly to recent source versions of Sage. It says: > > [...,needs rebase] > > How do I do that? It is not hard to manually fix the mismatches in the > old patches, but what does it mean to "re-base"? > > The existing tests pass, but I am aware of some other issues - some of > which I have posted to the list, including patches. And I have some > additional code that I have added to trac. By item c) below, do you > mean that I should accumulate all of my local changes plus Mike > Hansen's original stuff and post the result to 4036? I could certainly > give that a positive review since I am currently using it, but then > isn't a review by some else also required? > > Actually like most people I expect, I have to admit that with my > limited available time the rate at which Sage source code changes > makes it hard for me to keep up. Since I want to accomplish other > things with Sage and Axiom besides development work and no one has > expressed much interest in the interface, this issue has just been > pushed to the bottom of the pile until someone posts something that > seems directly related. > > Regards, > Bill Page. > > On Sat, Jan 17, 2009 at 12:52 PM, David Joyner <wdjoy...@gmail.com> wrote: >> >> I think roughly speaking what Michael is referring to is to ask you to: >> >> (a) apply the patches at http://trac.sagemath.org/sage_trac/ticket/4036 >> to the latest version of Sage >> (b) see if it applies cleanly, see if the tests pass, see if you find >> problems in the code or docstrings. Assume for simplicity there >> are no problems (this may be incorrect!). >> (c) issue a new patch with your changes which replaces all the other >> patches. >> (d) change the subject line from "needs rebase" to >> "positive review". >> >> If there are any questions, just ask on the trac ticket or on >> sage-devel. >> >> >> On Sat, Jan 17, 2009 at 12:28 PM, Bill Page <bill.p...@newsynthesis.org> >> wrote: >>> >>> Michael, >>> >>> In an email list usually it doesn't hurt much to point out the obvious >>> ... :-) But I don't understand. Haven't I reviewed them many times >>> here already? Perhaps I just don't understand the process... Overall >>> there does not seem to be very much interest in the fricas package for >>> Sage, so I haven't had much incentive to try to do more. Specifically: >>> what can I do to help get these patches into Sage? >>> >>> Regards, >>> Bill Page. >>> >>> On Sat, Jan 17, 2009 at 12:15 PM, mabshoff <mabsh...@googlemail.com> wrote: >>>> >>>> >>>> >>>> On Jan 17, 8:56 am, Bill Page <bill.p...@newsynthesis.org> wrote: >>>>> On Sat, Jan 17, 2009 at 10:30 AM, luis wrote: >>>> >>>> <SNIP> >>>> >>>> Hi Bill, >>>> >>>>> If you still have questions, please ask... And also try to encourage >>>>> the Sage/FriCAS developers to review this ticket so that we can >>>>> finally get it into Sage! :-) >>>> >>>> I don't want to point out the obvious, but since you have been using >>>> those patches and are also familiar with Axiom why don't you review >>>> them? >>>> >>>>> Regards, >>>>> Bill Page. >>>> >>>> Cheers, >>>> >>>> Michael >>> >>> > >>> >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to sage-devel-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
