2008/12/8 daveloeffler <[EMAIL PROTECTED]>:
>
> On Dec 8, 1:07 pm, "John Cremona" <[EMAIL PROTECTED]> wrote:
>> Are there two different ordering issues here: (1) do zeroes go at the
>> beginning or at the end? (2) Does each nonzero entry divide the next,
>> or the previous?
>
> The ordering is meant to correspond to inclusion of ideals, so if 1's
> are at the beginning, 0's will be at the end and vice versa.
OK. I vote for 1s at the beginning and 0s at the end.
>
>> I agree that this needs sorting, but if you change smith_form() then I
>> hope you will do a search_src("smith_form") and deal with what comes
>> up! (Answer: apparently very little outside of doctests, and one of
>> those is your own eta product application. But I have used it in a
>> patch which has been merged in 3.2.2 also!)
>
> Which one?
I meant #4536 but that was already in 3.2.1: it is the line in
number_field_ideal.py here:
sage: search_src("smith_form")
----------------------------------------------------------------------
| Sage Version 3.2.1, Release Date: 2008-12-01 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
matrix/symplectic_basis.py: \code{smith_form} implementation.
matrix/symplectic_basis.py: \code{smith_form}.
matrix/symplectic_basis.py: sage: E.smith_form()[0]
matrix/symplectic_basis.py: sage: E.smith_form()[0]
modular/etaproducts.py: S,U,V = Mlift.smith_form()
rings/number_field/number_field_ideal.py: D, U, V = M.smith_form()
matrix/matrix_integer_dense.pyx: \code{smith_form}.
matrix/matrix_integer_dense.pyx: sage: E.smith_form()[0]
matrix/matrix_integer_dense.pyx: WARNING: This is MUCH faster
than the smith_form function.
matrix/matrix_integer_dense.pyx: SEE ALSO: smith_form
matrix/matrix_integer_dense.pyx: def smith_form(self):
matrix/matrix_integer_dense.pyx: sage: D, U, V = A.smith_form()
matrix/matrix_integer_dense.pyx: sage: D, U, V = A.smith_form()
In this case there are no 0s and the order does not matter, so you are ok.
John
>
> David
> >
>
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
