I'll have to wait until I get home from work to test it out but the patch looks like you've added a lot of nice functionality. My original thought was to include more of the legend options in the method itself (instead of having several methods which set them) but you have so many options, that would be difficult. I wonder though if you can have just one method called legend_options, which of course then has tons of keywords, incorporating all the methods you have for method options?
Also, what if you make a plot, then add legend #1, then add a different legend #2 (with maybe different options)? Does the legend #1 get cancelled out? Just curious. As I said, I'll try it out later, but thanks for the very nice work! On Tue, Oct 21, 2008 at 10:08 PM, Arnaud Bergeron <[EMAIL PROTECTED]> wrote: > I implemented some code to put legends on 2d plots. > > It currently works, but I would like comments on the interface or > better ways to do some things before I put the code up for review in > trac. > > I am aware that the code needs proper documentation, I'll do that tomorrow. > > Also, should I put a deprecation warning on the label option for plot > or is it considered complimentary? > > Arnaud > > > > --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
