On Sat, Apr 5, 2008 at 2:35 PM, Justin C. Walker <[EMAIL PROTECTED]> wrote: > > Hi, Dan, > > A quick comment: > > > On Apr 5, 2008, at 09:38 , Daniel Bump wrote: > > > > > > I found that the G2 fundamental weights in combinat/root_systems.py > > are the negatives of what they should be. > [snip] > > > Since this is a genuine bug and trivial to fix I gave > > it priority major. Let me know if that was wrong. > > I think that the nature of the fix (e.g., trivial vs. not trivial) > does not have an impact on its priority. > > The fact that the code gives mathematically incorrect results does > have an impact, and for that reason, it should be major.
+1 In fact, any code that blatantly gives mathematically incorrect results should -- in my opinion -- always be marked a BLOCKER in trac. No matter whether the relevant mathematics is small or big or important or not. If nothing else, if a function is known to return false results on any input, we should do something to make that crystal clear (in the docs, print warnings, etc.), even if we can't easily fix the problem. -- William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://www.sagemath.org -~----------~----~----~----~------~----~------~--~---
