Hi,

Currently ci is in good shape except codecov/patch. 

codecov/patch works well: it reports the coverage change, and fails for a 
PR that does not test every code path. However, it is a problem that 
codecov/patch failure make the whole check for the PR fail.

*It is not our coding standard that a doctest is added for every code path. 
*A common example: we add "try except: ..." clause, but we do not add a 
doctest for the ... code path. 

Hence we learned to ignore check failure due to codecov/patch failure. It 
is annoying to "check and then ignore".

Proposal: have codecode/patch report but not fail.


Kwankyu

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/c8903804-b5a2-45c3-aac1-d13148a92786n%40googlegroups.com.

Reply via email to