1) Brial is too broken for being an optional package. 2) It should be a separate PR, not one doing 10 other unrelated changes, and touching 600+ files in the process
On 29 June 2024 20:57:31 BST, Matthias Koeppe <matthiaskoe...@gmail.com> wrote: >Still waiting for review: https://github.com/sagemath/sage/pull/36380 > >I had hoped to get this into the Sage 10.4 release. > > >On Monday, June 10, 2024 at 10:23:13 AM UTC-7 Matthias Koeppe wrote: > >> I'll remark that the approach of my PR >> https://github.com/sagemath/sage/pull/36380 takes brial to the same level >> as the existing optional packages bliss, coxeter3, sirocco, tdlib, etc. and >> applies the same approach to the Sage library code depending on the >> library: It defines a separately buildable, pip-installable distribution >> *sagemath-brial*. >> The rest of the Sage library, still shipped as *sagemath-standard*, is >> isolated from the problematic dependency on brial. >> >> That's an illustration of how the modularization project improves >> portability and makes it easier for downstream distribution to carry the >> Sage library. >> >> On Sunday, June 9, 2024 at 5:23:05 PM UTC-7 Matthias Koeppe wrote: >> >>> A milder change, demoting it to optional, is ready for review in >>> https://github.com/sagemath/sage/pull/36380 >>> >>> On Sunday, October 1, 2023 at 12:29:55 PM UTC-7 Matthias Koeppe wrote: >>> >>>> I propose to demote this package to experimental. >>>> - It has been declared dead at least once - >>>> https://martinralbrecht.wordpress.com/2015/06/13/polybori-is-dead-it-needs-your-help/ >>>> - It has no upstream maintainer (except for ermergency fixes by Francois >>>> Bissey) - https://github.com/BRiAl/BRiAl/graphs/contributors, >>>> https://sourceforge.net/projects/polybori/ >>>> - It has been dropped from Debian testing, where it seems to block >>>> SageMath upgrades (Sage is stuck at 9.5 in Debian/Ubuntu) >>>> - The conda and homebrew packages of brial lead to segfaults ( >>>> https://github.com/sagemath/sage/issues/35595, >>>> https://github.com/sagemath/sage/issues/34780) >>>> - It is disconnected from the advances in SMT (satisfiability modulo >>>> theories) over the past decade (representative paper: >>>> https://arxiv.org/abs/2305.00028v2) >>>> >>>> >>>> >>>> > >-- >You received this message because you are subscribed to the Google Groups >"sage-devel" group. >To unsubscribe from this group and stop receiving emails from it, send an >email to sage-devel+unsubscr...@googlegroups.com. >To view this discussion on the web visit >https://groups.google.com/d/msgid/sage-devel/08c864e3-7323-4544-907d-ceeb33fc34a5n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/64865C6C-257A-48FB-B40C-070057002201%40gmail.com.