Essentially +1 but might want to consider cases when its 2 vs 1 as requiring at least one other person involved. (Sorry for being late to realize this.)
Best, Travis On Monday, March 4, 2024 at 5:23:39 PM UTC+9 David Roe wrote: > With no further discussion on this thread > <https://groups.google.com/g/sage-devel/c/XDvKkMRoDk4>, I'm calling a > vote on a new process for resolving disagreements on a PR. > > *Proposal* > It is now allowed to vote on disputed PRs directly on Github rather than > bringing them to sage-devel. Working things out amicably is preferable, > and anyone is welcome to ask on sage-devel for more eyes on a PR. If you > notice a serious issue with a PR, it is acceptable to change it to Needs > Work (and make a comment!) as an initial step, but if the author or > reviewer do not agree then process below should be followed instead. This > process is intended as a lower-intensity method for resolving > disagreements, and full votes on sage-devel override the process described > below. > a. When there is disagreement about whether a PR should be merged, anyone > may mark a PR as disputed. > b. There is no scheduled vote, but rather an ongoing poll based on > opinions expressed by developers on the PR (these opinions can be expressed > via previous positive reviews or explicit comments giving approval). The > PR author is presumed to vote in favor; if they give up or no longer favor > the PR they have the right to close the PR overall without any further > voting. > c. If the total number of positive votes is at least twice the number of > negative votes, anyone involved may set the status to *positive review*; > if the total number of positive votes is less than twice the number of > negative votes, anyone involved may set the status to *needs review*. > When either of these actions is taken, the person changing the status must > list the people they are counting as positive and negative votes in a > comment using @ mentions. > d. The final decision on merging a disputed PR remains with the release > manager, and we encourage the release manager to give enough time for > everyone to express an opinion. > > Voting will be open until Wednesday, March 13. > David > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/cbf5aad0-d826-4056-8093-a11a3d4b6e0bn%40googlegroups.com.
