Hi John, None of the above. I think maintaining good programming practices is important for the codebase and it is a good thing to teach contributors who might not understand. Hence, we should spend the time having them get it into a format that is acceptable for Sage. In the end, it should play nice with the current matroid code, but I don't think that is a requirement for a new feature.
Best, Travis On Wednesday, November 22, 2023 at 8:27:31 AM UTC+9 John H Palmieri wrote: > This post concerns https://github.com/sagemath/sage/pull/36492. The main > topic of that PR is matroids about which I know almost nothing, so I am not > the right person to review it. The structure of the PR perhaps opens up > broader questions. The author has some new code, along with a PDF > documenting it, and it is currently not designed to be incorporated into > the existing sage.matroids module, but as more of a standalone piece of > code. > > - Should we have a "contrib" directory where we can easily include efforts > like this? > - Should this particular code be instead included in our thematic > tutorials? (If so, it needs someone to shepherd it through the process.) > - Or should this code be folded into the existing `sage.matroids` stuff? > > -- > John > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/9e9e36be-68d2-4771-b5a3-1527321f673bn%40googlegroups.com.
