> I think this is too verbose. In particular, the message "kwankyu
requested changes for this PR" is redundant.
>From the point of view of a developer familiar with Trac status labels, I
agree. However, a key goal of the GitHub migration was to attract new
developers who are familiar with the GitHub workflow but have no knowledge
of Trac. The comment will show them that the label s: needs work is used
as a synonym for request changes. However, note that the comment is the
body of the request changes review which cannot be omitted:
gh pr review 35172 -r
body cannot be blank for request-changes review
Kwankyu Lee schrieb am Sonntag, 3. September 2023 um 07:54:20 UTC+2:
> Thanks.
>
> I noticed one defect (nothing serious). For "closed" event, the message is
> succinct.
> -------------------------------------------
>
> [image: Screenshot 2023-09-03 at 2.43.25 PM.png]
> -------------------------------------------
> Now for adding status label ("s: needs work"), the message is
> -------------------------------------------
> [image: Screenshot 2023-09-03 at 2.48.07 PM.png]
> -------------------------------------------
> I think this is too verbose. In particular, the message "kwankyu requested
> changes for this PR" is redundant.
>
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sage-devel/9e5fa9cf-d947-4d13-8b69-99769146a8bdn%40googlegroups.com.
