I tried using mypy, and I also just ran "sage --tox -e pyright", and neither seems to flag the conflict between the signature "def signature(self) -> Integer:" and the output, which is some arithmetic with "len(...)" and hence a Python int. (And both mypy and pyright produce a ton of warnings, so if either is managing to flag anything worth fixing, it's likely to get drowned out. Or maybe I'm using them wrong...)
On Wednesday, September 6, 2023 at 1:45:10 PM UTC-7 Matthias Koeppe wrote: > On Wednesday, September 6, 2023 at 11:02:15 AM UTC-7 Dima Pasechnik wrote: > > Should we run mypy on all the *.py files, at least, in our CI? > > > We already have "sage --tox -e pyright", which is considered a better > choice than mypy. > > We are also running it in the GitHub CI as part of the Build & Test > workflow. > > See https://doc.sagemath.org/html/en/developer/tools.html#pyright > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/c99bdd6e-0fae-45e2-aafa-12525f6eea0bn%40googlegroups.com.
