On Wed, Jun 15, 2022 at 9:20 AM Kwankyu Lee <ekwan...@gmail.com> wrote: > > Hi, > > The ticket > > https://trac.sagemath.org/ticket/33996 > > fixes the issue "ascii_art fail in jupyter notebook" raised in > > https://groups.google.com/g/sage-support/c/1a7cBp580CM > > We worry that the fix would have a bad side effect with other user > interfaces, like emacs. > > So please test the fix with your favorite sage interface. Thank you.
I think this fix is an API change. We have no control over what fake ttys Sage users are using. What earlier returned False might now lead to an error. So if you want to remove that try/except, you must deprecate it first. IMHO I'd better have try/except retained (your fix applied in the body of try) Dima > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sage-devel/08a5e0db-83d4-4969-b267-8812d16aef23n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/CAAWYfq09nBHVEixG_Fi%3DaM1pAUMLYHMvTQwffdEL%2B_oNcSiaAQ%40mail.gmail.com.
