On Mon, 2021-01-25 at 23:19 -0800, Siddharth Bhat wrote: > Hey all, > > I'm very new here, so I'm unsure how this works; > I submitted a patch on saturday that implements chokesly > decomposition for > sparse matrices by calling out to cvxopt.cholmod: > https://trac.sagemath.org/ticket/13674 > > I'm trying to figure out how I can have the patch reviewed. I set > the > status to needs_review; That doesn't seem to have garnered any > attention :) >
Setting the ticket to "needs review" makes it show up in the list of tickets needing review. Unless you know someone who might be interested in reviewing it... the next step is simply to wait. It can take weeks or months until someone qualified and interested stumbles upon it. But you are in luck: on https://trac.sagemath.org/ticket/10332 I've implemented a numerically stable block-LDLT factorization that I think can be used in your "if not self.base_ring().is_exact()" branch, so you don't have to call out to cvxopt or convert things to float when the base ring is inexact. I'll take a closer look and post some comments on your ticket. > 1. Should I have created a new trac ticket to fix the issue? > 2. Is there some metadata I forgot to update, and hence the patch > does not > show up in the review queue? > 3. Should I have "bump"-ed the patch in Trac? > No, no, and no =) -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/ca50c38269be8058cdd3fcac23faed88e2062779.camel%40orlitzky.com.
