Le mercredi 4 novembre 2020 10:00:41 UTC+1, Adam Larat a écrit : > > Hi everyone, > > I hope I am posting at the correct place. > > There is a minor bug in the verbose output of the small_roots function in > Z/nZ[X]. > At line 567 (Sage 9.2, I might not be absolutely up to date…) of the > build/pkgs/sagelib/src/build/lib.linux-x86_64-3.8/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx > > file, the variable epsilon is output as a integer when it is actually a > float > 567: verbose("epsilon = %d"%epsilon, level=2) > I attach a minimal working example which outputs variable epsilon as 0 > when it is indeed strictly positive. > I would be glad to contribute if you indicate me the procedure to follow, > or someone more powerful than me could just change the line to > 567: verbose("epsilon = %f"%epsilon, level=2) > and push on the repo? > > Thank you very much for all your work, > > Adam >
Hi Adam, thanks for noticing and reporting. The easiest way to contribute the change you suggest is as follows: - Open an account at GitLab.com - Fork the repository https://gitlab.com/sagemath/sage - Visit your forked copy of the repository at gitlab.com - Edit the file there - Send a merge request This will automatically create a ticket on the Sage Trac server with your changes, and from there they can be reviewed by other developers and eventually merged. Let us know if you run into any trouble. Kind regards, --Samuel -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/9c59b938-eee1-4409-8674-ac6b9eb9e4d0o%40googlegroups.com.