Jaap Spies wrote:
> William Stein wrote:
> 
>>>> sage: v = vector(RDF, (1,2))
>>>> sage: plot(v, type='arrow').show()
>>                    ^^^^^^^^^^
>>
>> Could you call this parameter something besides "type"?  I
>> don't like "type" since it is a builtin function name:
>>
>> sage: type(4/5)
>> <type 'sage.rings.rational.Rational'>
>>
>> so using type in your code in a completely different way
>> makes it harder to read.   Maybe replace "type" by "kind"?
>>
> 
> May I suggest plottype?
> 

I've uploaded vector-plot-updated.patch, which:

* fixes the Arrow issue
* fixes the eps doctest issue
* changes the type option to plot_type.  If it would be better to be 
"kind", let me know---it's a trivial change to the patch.  I don't think 
I have a preference either way.  Is there a convention in Sage?
* removes the ".show()" at the end of each doctest plot.  The plots seem 
to show up automatically with jmol now (in the notebook and from the 
command line), so do we need to put .show() at the end of a plot 
statement anymore?

If someone could review the updated patch, I'd appreciate it!

Thanks,

Jason


--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/
-~----------~----~----~----~------~----~------~--~---

Reply via email to