Michael, I think we have some crossed wires again, presumably my fault as usual.
The spkg I posted yesterday, and also the slightly patched one you then made from it, build perfectly if you untar the spkg and cd into src then do make and make check. But despite having the spkg suffix on this I made no claims at all that this version would work with Sage 2.9.1! In fact I said specifically that the Sage interface would need to change to take into account the changes I made in the mwarank->cremona->eclib migration. Hence no-one should be trying to use this withing Sage until the wrapping has been changed to match the (fairly minor) changes in interface between the last cremona* and the first eclib*. These changes were only made to provide the extra functionality asked for by Sage users.... Happy New Year to all, John On 01/01/2008, mabshoff <[EMAIL PROTECTED]> wrote: > > > > On Jan 1, 1:12 am, mabshoff <[EMAIL PROTECTED] > dortmund.de> wrote: > > Hi, > > > > I just opened #1650 in trac which is a test failure of tset. All the > > relevant information is there, but it looks like another template.h > > issue vs. NTL, but I hadn't had time to investigate. > > > > If you feel brave please test the spkg located at > > > > http://sage.math.washington.edu/home/mabshoff/eclib-20071231.p0.spkg > > > > Please run make check manually or do an export SAGE_CHECK=Yes before > > running spkg-install or make and report any test failure. I am > > thinking of making the running of spkg-check mandatory since it is > > very quick and should help shake out bugs quickly. > > > > But make sure to wait for the inevitable patch that fixes some > > includes since otherwise your Sage install will be potentially broken > > after the next "sage -b". The fix is obvious and should take only a > > couple minutes. Watch #1649 for the patch itself. > > Ok, trouble ahead. I guess as John did point out the interface did > change and I now get compilation errors: > > cc1plus: warning: command line option "-Wstrict-prototypes" is valid > for Ada/C/ObjC but not for C++ > sage/libs/mwrank/wrap.cc: In function 'char* > two_descent_getbasis(two_descent*)': > sage/libs/mwrank/wrap.cc:246: error: invalid initialization of > reference of type 'const std::vector<Point, std::allocator<Point> >&' > from expression of type 'std::vector<P2Point, std::allocator<P2Point> > >' > sage/libs/mwrank/wrap.cc:159: error: in passing argument 1 of 'char* > point_vector_to_str(const std::vector<Point, std::allocator<Point> > >&)' > error: command 'gcc' failed with exit status 1 > sage: There was an error installing modified sage library code. > > P2Point is a rational point I assume. So I am hoping now that somebody > else will do the work to fix this since I am not very familiar with > the code and also the design of mwrank. Since #1650 is still out there > we might have to postpone the merged of the new eclib.spkg > > > Cheers, > > > > Michael > > I am catching some sleep now - back in about 8 hours, finally getting > some more work done on 2.9.2.alpha0. > > Cheers, > > Michael > > > -- John Cremona --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
