On Dec 5, 2007 10:21 AM, mabshoff <[EMAIL PROTECTED]> wrote: > > > > On Dec 5, 4:55 pm, "John Cremona" <[EMAIL PROTECTED]> wrote: > > Since it seems that most of the problems everyone now has are caused > > by the mwrank.spkg -> cremona.spkg switchover, and given that 99.9% of > > the extra functionality has not yet been wrapped into Sage and is > > hence unavailable from Sage anyway, why don't we just chuck out the > > cremona.spkg into an optional extra for the time being, as no-one wil > > notice anyway? > > Oh, William will and what we are experiencing now will happen again > once we would remerge it. See it as a payment to you for contributing > your code :) > > > Otherwise everytime I look at sage-devel I just feel guilty at > > apparently being the cause of everytone's grief while giving them no > > apparent benefit. > > Don't worry, other packages have caused way more grief. > > > The only problem I can see with this is that the various edits which > > have had to be done to my source code to make it gcc4.2+ compatible > > have not been made to the mwrank sources. > > mwrank compiles with gcc 4.2, so that has never been a problem. I am > not sure who fixed it, but the changes should have certainly flown > back into your tree. With the removal of mwrank.spkg that issue will > go away. > > I am working on getting mwrank working with the cremona.spkg version, > i.e. the removal of the original mwrank.spkg. I will also send you a > patch for the gcc 4.3 fixes shortly. I will do some build testing on > my end to make sure I haven't broken anything and then merge it into > 2.9. > > > John > > > > I had a look at trac and currently the following tickets related to > mwrank are open: > > #1058 the mwrank interface barfs on bad input > #1233 mwrank wrapper causes crashes and error on non-minimal curves > #1248 mwrank wrapper defect > #1256 mwrank*.spkg now redundant, included in cremona*.spkg > #1402 mwrank: "Invalid read" while Searching for Points > #1403 mwrank has termination issues > > I will take care of #1256 now. If you have some time can you please > give an assessment of the other tickets and tell us which ones you > consider to be in your realm of your code base and which ones in the > realm of Sage?
And just to add to that, feel free to say "please just send me what you think are fixes for everything, and I'll just have a look". I can personally think of numerous people reading this email right now who could easily fix things like #1058 -- e.g., I know Justin Walker could easily make short work of it... if he knew for a fact he wasn't stepping on your toes by creating a fix. -- William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---
