On 10/22/07, Nils Bruin <[EMAIL PROTECTED]> wrote: > See: > > http://sagetrac.org/sage_trac/ticket/768 > > I have updated the attached patch to be clean against 2.8.8.1. When I > checked the edit() command in sage 2.8.8.1, I realized it was really > broken -- It doesn't work if EDITOR is unset in the environment. The > patch attached to the trac ticket is supposed to fix that.
I'm generally happy with this patch, though I don't agree with removing the bg option. Perhaps you're removing that functionality because your particular workflow is more rigid than mine. For example, I use emacs quite a lot, both in a console (especially when I login to other machines), but also as a popup separate application. When I use emacs in console mode, putting the editor in the background is very frusting, and doesn't work at all. When I use emacs as a separate popup application, it is very very frustrating if the console session freezes, since often the reason I'm popping up the editor is to create some examples in the console and paste them into the docstring of a function. In both cases the command name is exactly the same "emacs". So please change the patch back to have the bg option. This is a lot like black on white versus white on black. Most people exclusively use one or the other mode, and it's impossible to know which from the application's point of view. So applications have to support both and make it easy to switch between generating colors for each. I often switch between using emacs and vi, both in window and console mode, and between black on white and white on black, depending on my mood, eye strain, computing I'm logged into, etc. So it needs to be easy to support changing modes. The bg= option to edit is 3 lines of code and does just that; it allows one to very easily override automatic defaults on a per-use basis. -- William --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to sage-devel@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sage-devel URLs: http://sage.scipy.org/sage/ and http://modular.math.washington.edu/sage/ -~----------~----~----~----~------~----~------~--~---