السلام عليكم،

On Tue, May 15, 2012 at 04:18:44PM +0200, Abdelmonam Kouka wrote:
> Brother Ahmed can please anser my question: what we need to add/import
> http://software.opensuse.org/download.html?project=home:abouzakaria&package=elforkaneto
> sabily ppa?
---end quoted text---

  I did some enhancements to the Debian packaging, and uploaded to our 
  staging PPA [1]. Please test the package and give me feedback, so that 
  I would copy it to the Sabily PPA.

  I have some notes for bro Abdalrahim G. Fakhouri though:

  * There is a spelling error (aplication should be application, double 
    'p') in the following files: dialogoption.ui, *.ts, elforkane_ar.qm
  * Please set a license for your work (Waqf or GPL3 for example)
  * Regarding elforkane.desktop file:
    + It is un-usual (and if I recall correctly, unsafe too) to make it 
      executable, I suggest removing the executable permission (and 
      hence remove the interpreter line in it)
    + It has a deprecated key (TerminalOptions), there is a utility 
    called desktop-file-validate which is useful to make sure that the 
    .desktop file has valid entries, please use it to check your file.

  و جزاكم الله خيراً.


[1] https://launchpad.net/~sabily.team/+archive/staging

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Mailing list: https://launchpad.net/~sabily.team
Post to     : sabily.team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~sabily.team
More help   : https://help.launchpad.net/ListHelp

رد على