On 12/22/23 16:10, Emanuele Giaquinta wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know
the content is safe.
Hi,
On Thu, Dec 21, 2023 at 01:46:14PM +0800, changqing...@windriver.com wrote:
When doing cross-compile, native tic's TERMINFO usually
set as a native dir, which could not the target install dir,
which will cause rxvt-unicode terminfo will be wrongly installed.
set the outdir explicitly to install them to correct dir.
the patch does not look correct to me, as it hardcodes the terminfo
location, with no guarantee that it is the one used by ncurses in the
target environment. The correct solution should be to use the tic
binary from the target enviroment with
TIC=<path/to/tic> ./configure
Hi,
Thanks. You are correct, the hardcodes path is not right. But during
cross compile, the target arch maybe
different with the host arch. so we cannot use the tic from target env.
So I think maybe it can be changed like this:
if TERMINFO_PATH ="":
@TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo || \
@TIC@ $(srcdir)/etc/rxvt-unicode.terminfo
else:
@TIC@ -x $(srcdir)/etc/rxvt-unicode.terminfo -o $(TERMINFO_PATH) || \
@TIC@ $(srcdir)/etc/rxvt-unicode.terminfo -o $(TERMINFO_PATH)
by default, TERMINFO_PATH is empty, it works like current way. if cross
compile need
to set it's own path, just set TERMINFO_PATH, and it have responsibility to
ensure the path
is the same as what will be used in target env.
if you don't have other concerns about above way, I will send an v2 patch.
Thanks
Changqing
Emanuele
_______________________________________________
rxvt-unicode mailing list
rxvt-unicode@lists.schmorp.de
http://lists.schmorp.de/mailman/listinfo/rxvt-unicode
