Hello Fred,

Thanks for your reply.

On Mar 15, 10:25 pm, Frederick Cheung <[email protected]>
wrote:
> The only change I might make to that is where step 11 goes - depending
> on the change you are making it may be advisable to gather some
> opinions earlier on rather than after you've written a patch.
I am not too proud of this patch, Fred. I think all the SQL code
should move into the DB connection class. Rather than submitting a
patch, which I feel could be done better, I'd like to get some more
comments from the core team (e.g. Is the connection class really the
best place? or How to minimise the effect of my intended change on all
the DB adapters out there?). Only then I would feel comfortable to
submit anything.

I might follow MaD's advise - thanks for that MaD - and send another
message to the rails-core group first and see what the experts have to
say.

Salut,
  Mathias
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Talk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to