Couldn't figure out how to assign it to you specifically, but I created the pull request here:
https://github.com/rails/rails/pull/28812 Thanks again for the help! On Wednesday, April 19, 2017 at 12:53:31 PM UTC-6, Kasper Timm Hansen wrote: > > Pull requests are made to get feedback, so if you’ve got the code why not > just open one? :D > > Feel free to use "r? @kaspth" to assign it to me. > > Den 14. apr. 2017 kl. 23.56 skrev Joshua Klina <[email protected] > <javascript:>>: > > Hi Kasper, > > I started diving into this and added a way to incorporate a Rails app into > the load path for commands. The Railties test suite seems to pass, but I > wanted to get some feedback before submitting a pull request. > > https://github.com/rails/rails/compare/master...jklina:thor_load_paths > > Thanks! > > On Thursday, April 6, 2017 at 6:39:40 PM UTC-6, Joshua Klina wrote: >> >> While Rails has great support for adding Rake tasks there is currently no >> information on how to add Thor commands, despite Thor playing an active >> role internally. I find Thor commands to be better for handling more >> sophisticated interaction from the user and they're great for testing. >> There already seems to be solid conventions in place for Rails/Thor >> commands for either engines or applications however, this is currently >> undocumented. >> >> I just wrote an article describing how an app or engine author can add >> their own namespaced Commands here: >> http://www.joshklina.com/posts/adding-thor-commands-to-rails >> >> I'd be happy to create a patch that adds a Command generator and write up >> documentation if you folks would be interested. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at https://groups.google.com/group/rubyonrails-core. > For more options, visit https://groups.google.com/d/optout. > > > -- > Kasper > > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/rubyonrails-core. For more options, visit https://groups.google.com/d/optout.
