Hi Rafael, thanks for your response. My wife went through a surgery on
Friday and is under recovery for a few days and I'm alone with the
babies during the weekend. I'll try to find some time to create such PR
tomorrow.
But, before I do that, I'd like to ask: is this incompatible change
really intentional?
I mean, I can see why Raw should be the default over ERB, but shouldn't
the resulted string be flagged as html safe by default?
In other words, could you describe a real scenario where applying html
escaping over a raw partial would make sense?
I'm just curious. If you decide this change indeed worths the breakage I
can try to submit a PR with a better warning complementing the current
explanation.
Best,
Rodrigo.
Em 06-05-2016 14:51, Rafael Mendonça França escreveu:
That makes sense. Thank you for pointing out. Do you have a suggestion
how to improve it? Could you open a pull request?
On sex, 6 de mai de 2016 at 06:46 Rodrigo Rosenfeld Rosas
<[email protected] <mailto:[email protected]>> wrote:
Here is the relevant section in the changelog, I think:
https://github.com/rails/rails/blob/v5.0.0.beta4/actionview/CHANGELOG.md
"Change the default template handler from ERB to Raw.
Files without a template handler in their extension will be rendered
using the raw handler instead of ERB.
Rafael Mendonça França"
I always give it a glance to the changelogs before trying to
upgrade but
this documented change didn't grab my attention enough to think
that it
might impact on my application.
There are a few performance/analytics/monitoring related scripts that
are loaded directly in an inline script in one of my view layouts.
They are loaded like this:
<script type="text/javascript">
<% unless params[:monitoring] || Rails.env.development? -%>
<%= render '/common/pingdomjs.js' %>
<% end -%>
...
After this change I had to move it to:
<%= render('/common/pingdomjs.js').html_safe %>
I think this is not an uncommon pattern and that maybe the need of
such
changes to non ERB files rendering should be highlighted in the
Changelog to grab the reader's attention.
This is just a sugestion to improve the changelog before Rails 5 final
is released in order to make the upgrade process smoother.
Best,
Rodrigo.
--
You received this message because you are subscribed to the Google
Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected]
<mailto:rubyonrails-core%[email protected]>.
To post to this group, send email to
[email protected]
<mailto:[email protected]>.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to [email protected]
<mailto:[email protected]>.
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Ruby on
Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
