Hi y'all,

We are running into CookieOverflow errors due to judicious use of flash.now 
which seemed odd. After some digging I found that the full flash, including 
discarded values, is being saved into the session between each request, yet 
the discarded values are immediately case away when reconstituting the 
values. So why not discard them before marshalling? Seems to work. Saves a 
lot of cookie bytes, too.

Also revealed a bug where functional controller tests which removed all 
flash entries weren't removing the marshalled flash from the session when 
processing and recycling requests, a difference in behaviour to the actual 
middleware.

Here's a pull request:

https://github.com/rails/rails/pull/18721

Thanks!

Sam

-- 
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.

Reply via email to