I posted my proposed changes to the Calculations API, and resulting SQL queries here:
https://gist.github.com/3681183#file_calculations_b.rb I'm preferring the "calculations_b.rb" version over the one with a separate grouped_count method: it would be a less intrusive change, and when we need to pass a :group option anyway, it doesn't make sense to repeat `grouped_count(group:...)` when `count(group:...)` is obvious. Andrew Vit On Thursday, October 11, 2012 6:55:48 PM UTC-7, Andrew Vit wrote: > > I'd like to get some traction or feedback on issue #7121 so I know if it's > worth me doing it. What are the objections to: > > 1. Fixing brittle calculation methods via subqueries? > 2. Requiring count(:group=>:author_id) option explicitly when we want a > Hash instead of Fixnum? > > Or am I the only one who thinks this is broken? :-( > > Andrew Vit > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-core/-/SbD9PQU4fD4J. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
