> Ok, I spent some time digging through commits and writing tests. The > tests I wrote actually don't have anything to do with reloading > because I couldn't find a recent commit that required any forking or > spawning to test. > > http://github.com/Manfred/rails/commits/railties-tests > > Josh, can you point me to a specific piece of code that would require > such a test?
Any of the changes like 69c049f5ab45bf9bfb0d269acea0773581905fd4 That fixed problems with storing AR objects in the session: 1) the session stores call marshall.dump 2) and the marshalling code checks respond_to? 3) and the dispatcher hook had triggered reload! 4) So the class that the instance refers to has been nuked (c.f. earlier discussions) 5) So the session serialization fails Great work so far, if you can figure out a reliable way to do regression testing with reloaded code, then I'll gladly (gladly!) apply it :) > Manfred > > On Feb 25, 8:15 am, Manfred Stienstra <manf...@gmail.com> wrote: >> >>> That sounds like a job for forking. >> >> >> That makes accumulating the failures from the child process >> >> essentially impossible though, you'd end up with crazy output >> >> intertwined with the parent process. >> >> Well, let's just talk code shall we (: I'll write up some stuff and >> present it to the mailinglist, we can debate whether it's a good >> solution afterwards. About support for testing on Windows: any help is >> appreciated, I don't understand Windows. >> >> Manfred > > > -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
