Hi, I've also been worried about the lack of testing present in some commits lately. ActionPack, and especially the Rack related code, seem to lack lots of necessary testing. Afaik the Rails policy used to be; have good test coverage or don't commit. Has this been changed?
Eloy On 18 feb 2009, at 09:52, Manfred Stienstra wrote: > > Hi guys, > > I've been seeing lots of commits lately without tests, for instance: > > > http://github.com/rails/rails/commit/b6e56efe07cb3c2e999216f995403aa9206226a2 > > http://github.com/rails/rails/commit/238a6bb62dc153743a0abc6eb1e35392ac799d65 > > http://github.com/rails/rails/commit/1dab1d380377f1a2a60da43bc22989d55632d246 > > http://github.com/rails/rails/commit/5c63be1f92edcd3ed60fae90b8eb129da19c5099 > > Most of these commits appear to fix some sort of regression, but no > tests are added to make sure we can catch such a regression in the > future. Is this done on purpose? > > Manfred > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
