On 7 Nov 2008, at 11:58, Rodrigo Rosenfeld Rosas wrote:
> > On 6 nov, 17:14, "Michael Koziarski" <[EMAIL PROTECTED]> wrote: >>> I'm willing to help on this, but I need to think what the core >>> developers think about this. >> >> I believe the support for a single symlinked directory is probably >> because of the way most capistrano deployments work, but you'd have >> to >> dig through the blame output to know for sure. Did that show >> anything >> of interest? > > "you'd have to dig through the blame output to know for sure". Sorry, > I know all the words individual meaning, but I couldn't understand > very well this phrase. English is not my native language. What did you > mean by digging through the blame output? the output of git blame (tells you when the lines in a file were last changed, so you can see who last changed, when and in what commit (and then hopefully the commit messages tells you why) Fred > > >> Feel free to add a comment-patch, then we can look at changing the >> implementation after 2.2 final ships. > > I'm discussing this with Joshua Peek on > http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/1296-simplify-glob-in-pathsrb-actionpack-to-get-a-cleaner-code#ticket-1296-6 > > I'm waiting for some orientation of how should I submit this patch... > If I should deprecate this support or not. How should I deprecate in > this case. I need to know if I could comment the code for better > understanding and if I could add a note to Rails documentation about > symlinked dir lack of support or one level support. > > My main concern is about making the code clearer. I've spent a lot of > time finding out why that line of code was written that way, when > trying to understand the Rails behaviour for rendering a template... > If at least there was a note in the Ruby documentation for the glob > method stating its symlinked dir limitation, it would be easier to > understand. > > Actually, I'm willing to send another patch to Rails guide to explain > how subtemplates can be achieved with Rails. It is not documented in > Rails documentation at all and I found it hard to get some references > at the time, mostly because of a lack of documentation of the render > behaviour. So, I intend to explain this on Rails guides or in the core > documentation. I still don't know which place would be the more > appropriate. While trying to understand why I could do subtemplating > the way I was doing I needed to search the Rails code, since that > method was not well documented. Then I found that line of code that I > couldn't understand why it was so complicated... Even the extra > unnecessary '*' adds further complication... > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
