On the bind variables fix, would it be possible to reduce the scope of changes required by having sanitize_sql return a subclass of string that preserves binding information for drivers that know how to interpret that info?
BindVariablesString#unbound_string would return the original query with bind variables intact, and BindVariablesString#bind_variables_array would return the bind variables themselves. The value of BindVariablesString would be the string after replacement of bind variables with literals, just as it is now, so drivers that don't know about the extended behavior wouldn't need any changes. This is just a though, I haven't traced through the code enough to be certain that the BindVariablesString would be passed through intact through all the layers of code (perhaps ActiveRecord creates a new string for instance, losing the bind variables). --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
