Hi Ebben, Thanks first of all for the review.
> On Mar 21, 2021, at 2:10 PM, Ebben Aries via Datatracker <nore...@ietf.org> > wrote: > > Reviewer: Ebben Aries > Review result: Ready with Nits > > One of the simpler YD reviews since this draft contains only a single module > with a single r/o leaf augment to various other BFD module nodes. > > 1 module in this draft: > - ietf-bfd-stabil...@2021-02-24.yang > > YANG compiler errors or warnings (pyang 2.4.0, yanglint 1.10.17, confdc > 7.2.3.4) > - warning: RFC 8407: 3.1: The IETF Trust Copyright statement seems to be > missing > - Minor issue just due to slight wording adjustment from copyright info > normally used in the draft/RFC itself > https://trustee.ietf.org/documents/trust-legal-provisions/tlp-5/ I cut and pasted the text from ’pyang —ietf-help’ and it still gives me the error. Go figure! > > > Module ietf-bfd-stabil...@2021-02-24.yang: > - Contact information should follow formatting seen in other published > modules. Just some minor cleanup/readjustments here. Do you e-mail addresses of the authors? If so, they were written as such to prevent online email extractors from extracting email addresses. > - Various augments will augment the respective 'session-statistics' container > however for 'bfd-lag:member-links/micro-bfd-ipv4', > 'bfd-lag:member-links/micro-bfd-ipv6' and 'bfd-mpls:sessions' these augments > sit in parallel to that container. Is there any reason this is not > consistent? > Good catch. Have added a path to “session-statistics” container. augment "/rt:routing/rt:control-plane-protocols/" + "rt:control-plane-protocol/bfd:bfd/bfd-lag:lag/" + "bfd-lag:sessions/bfd-lag:session/bfd-lag:member-links/" + "bfd-lag:micro-bfd-ipv4/bfd-lag:session-statistics" { > > General comments on the draft/modules: > - Section 7.2: It is stated the document registers "2" YANG modules when it is > infact only a single module Fixed. > > Overall, just minor nits and view as ready from a YANG doctor review > standpoint once the above is addressed Thanks Mahesh Jethanandani mjethanand...@gmail.com
