On Tue, Jun 25, 2013 at 3:25 PM, Radu Gheorghe <[email protected]>wrote:
> 2013/6/25 Rainer Gerhards <[email protected]> > > > On Tue, Jun 25, 2013 at 12:35 PM, Radu Gheorghe <[email protected] > > >wrote: > > > > > Hello rsyslog-users! :) > > > > > > I have a few suggestions, and I'm looking forward to your feedback > > > > > > 1. Should imfile be included in the base rsyslog rpm/deb package? > > > > > > I've noticed that, at least the RPM packages from the Adiscon repo > don't > > > include imfile, whereas most distributions (confirmed on CentOS and > > > OpenSUSE) include it. I think it's nice to have it there because there > > are > > > many apps who can't (or are difficult to configure to) log to syslog. > > > > > > > > I have to admit I thought we have a special package for it. But it > probably > > is a good idea to include it in the base package, especially as it does > not > > drag in any dependencies and is something that is quite often used. > > > > > Cool! :) Please let me know if you need any help in doing that. Otherwise > I'll keep an eye on the packages. And probably bug you with a reminder > every once in a while :) > > Andre is the one to bug, but he reads the list ;) > > > > > > If you think this is a good idea, I'd volunteer to do it (unless > someone > > > else wants to do it, of course). Disclaimer: I'm not a packaging expert > > and > > > I can't provide any guarantees on the timeline. > > > > > > Do you think there are other modules that should be included in the > > "core" > > > package? Please note that, some of them might require additional > > > dependencies. So they need to be chosen carefully. > > > > > > 2. Should all the modules have their own packages? I'm still talking > > about > > > the Adiscon repo here, but I'd guess some distributions will follow the > > > example. > > > > > > > > I'd say "almost all" but not "all". The repro contains some experimental > > code, like imttcp, which is not actually meant to be used in production. > > > > > Riight! There's no point in maintaining the ones that are not meant to be > used in production. As with the other one, poke me if you need any help. > > > > > > > For example, imfile doesn't have one. And, unless it will get included > in > > > the base package, one has to compile rsyslog manually to use it. I bet > > > there are others (eg: impstats) in the same situation. > > > > > > 3. Totally unrelated to the above: how do I write new tests? > > > > > > I've read a few things about the testbench recently but I still can't > get > > > my head around how to contribute new tests to rsyslog. I'd like to > write > > > tests, especially when I open a bug, to make sure it doesn't reappear > in > > > future versions. I've seen some bash scripts in the tests/ directory, > > but I > > > can't quite figure out how to run only the test I'm making. To test the > > > test :) > > > > > > Any pointers on how to do that? I'd gladly document a howto somewhere > > once > > > I figure it out. > > > > > > > That's a longer one ;) May I suggest to have a look at tests/diag.sh > first, > > and the look at one of the actual tests. Describing it in-depth currently > > goes over my head, but I can most probably provide answers. the core > thing > > to know is that all the hard work is encapsulated in diag.sh, and all > other > > tests just call into diag to make it perform things like start rsyslog, > > stop it, check output files and so on (except for some either very > special > > or very old tests). > > > > Does that help? > > > > > It does help a bit, thanks. I was suspecting that file to be one of the > core things. I'll look at it when I'll have time (which doesn't happen very > often, I have to admit), and ask specific questions as I go along. > > One question: is there any way to run specific tests, and not all of them? > I assume `make check` does all the tests, and I'm looking for a way to test > my test script without having to run everything. > my simple and well-working low-tech solution is to go the the tests directory and start the script in question. It requires some env vars to be set (done automatically in make check): export srcdir=/home/.../rsyslog/tests (actually just one ;)). Must be an ABSOLUTE path. Rainer > _______________________________________________ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you > DON'T LIKE THAT. > _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
