https://bugzilla.samba.org/show_bug.cgi?id=8475
Wayne Davison <way...@samba.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Wayne Davison <way...@samba.org> 2011-09-22 16:35:42 UTC ---
Looks like rsync_xal_free() was originally written to allow re-use of the
allocated memory (it leaves the malloced value unzeroed along with the "items"
memory), but only one of the 2 callers was freeing the item memory, and neither
was expecting it to stick around.
I have committed a fix that frees the memory and also avoids calling free on
the "items" list if no allocations were done. I decided to get rid of the
memory clearing, since no callers expect to re-use the allocated area -- one
discards the memory, and the other pre-clears it (using EMPTY_ITEM_LIST) before
each new/reused item is used.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
