https://bugzilla.samba.org/show_bug.cgi?id=7109
Matt McCutchen <m...@mattmccutchen.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|WONTFIX |
--- Comment #4 from Matt McCutchen <m...@mattmccutchen.net> 2011-06-05 00:48:12
UTC ---
(In reply to comment #3)
> Since the read function doesn't generate an error, it shouod be fine to just
> let any attempt to set user xattrs on a symlink generate an error. Is there
> anything I'm missing?
Yes: bug 7110. NO_SYMLINK_XATTRS is needed to trigger the code path that
converts the symlink to a regular file to be able to set the fake-super xattr.
Without it, rsync will try to set the xattr on the symlink, generating an EPERM
which is swallowed by a test you apparently wrote to allow fake-super to work
on a best-effort basis before the introduction of the NO_SYMLINK_XATTRS switch.
So, you can either detect the EPERM and convert the symlink to a regular file
then, or have a separate NO_SYMLINK_USER_XATTRS switch. But either way, the
EPERM test should go now that it is masking a failure that rsync is supposed to
be able to avoid.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
