https://bugzilla.samba.org/show_bug.cgi?id=8019
--- Comment #1 from Wayne Davison <way...@samba.org> 2011-03-19 23:02:16 UTC --- (In reply to comment #0) > - The fileflags variable was occasionally referenced without being initialized I'm not sure what you were seeing for this. You added some setting of the static fileflags variable to 0 for the non-fileflags option case, but that variable is always 0 when that option is off. I did change the bit that initializes F_FFLAGS(file) to ensure that force_changes w/o preserve_fileflags sets it to 0. I also made sure that the code that fakes the value into st_flags sets a 0 if --fileflags is off. > [...] > - syscall.c: Added make_mutable/force_change functionality to many of these > system calls I note that dirname() function expects a non-const string and may potentially change the buffer, so it can't be used in these syscall functions. I created a function that tweaks the path into a buffer and calls make_mutable() on the result, and then twiddled your new code to make use of it. I also enhanced make_mutable() a bit and simplified some of the existing make_mutable() calls. The result has been checked into the patches git repo. Thanks! -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
