On Mon, Sep 29, 2008 at 02:47:53PM -0700, Wayne Davison wrote: > reordering the args in the ifs so that an underflow can't trigger a > spurious successful test.
Actually, my change isn't good enough, since an underflow with the "if" vars reordered should actually indicate a match. So, my patch would need another compare to test for underflow. Your patch also needs an extra compare in the file1 >= file2 case: if (file1 - file2 <= modify_window && file1 - file2 >= 0) I guess I'll think about this more later. ..wayne.. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html