There are some warnings on uidlist compiling rsync under 10.3:

gcc -std=gnu99 -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c uidlist.c -o uidlist.o
uidlist.c: In function `match_uid':
uidlist.c:210: warning: comparison between signed and unsigned
uidlist.c: In function `match_gid':
uidlist.c:222: warning: comparison between signed and unsigned
uidlist.c:226: warning: comparison between signed and unsigned
uidlist.c: In function `add_uid':
uidlist.c:249: warning: comparison between signed and unsigned
uidlist.c: In function `add_gid':
uidlist.c:267: warning: comparison between signed and unsigned

On rsync.h line 414 we have:

#ifndef HAVE_ID_T
typedef int id_t;

On mac types.h line 106 we have:
typedef u_int32_t       uid_t;          /* user id */

Would it break things on other systems to change id_t from int to unsigned int?
If no, can we change this type?
If yes, can we have a 10.3 flag
#ifdef PANTHER
typedef unsigned int id_t;
#else
typedef int id_t;
?

Vitorio
-- 
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Reply via email to