Nathaniel Smith wrote: > On Sun, Feb 8, 2009 at 2:01 PM, Laurent Gautier <lgaut...@gmail.com> wrote: >> It turned out that a stale PYTHONPATH was getting an older version of rpy2 >> when running it on my end. >> So much for the cross-platform unifying bit. :/ >> >> Now the tip should build and run on Linux. > > It does work for me, though my internal code interpreter is now > twitching a bit, because your version of the patch basically leaves in > the bad code, but then it turns out okay because gcc's optimizer takes > out the bad code before the linker can see it. Not terribly obvious.
Sorry about it. That's bad practice, and first of all because gcc is not the only compiler around. This will be corrected immediately. > It would make my subconscious happier if instead of: > #if !( defined(HAVE_AQUA) || defined(Win32) ) > [...] > return NULL; > #endif > [...] > R_ProcessEvents(); > [...] > > We had: > #if !( defined(HAVE_AQUA) || defined(Win32) ) > [...] > return NULL; > #else > [...] > R_ProcessEvents(); > [...] > #endif > >> Thanks for following the bitbucket tip. > > Oh, well, I send all these patches because I am using the > functionality they add, and it's easier to follow tip than to maintain > my own hacked-up fork :). I got myself into trouble starting rpy2 this way. Be careful ;-). > Perhaps it would be better to send them against the stable branch, > though? You tell me. default/tip is fine. The workflow is not frozen, but the current general rule is that I am trying to first apply patches to default/tip, then backport to version_2.0.x if the patch does not break the existing API in 2.0.x. Once more, thanks for the patches; having more eyes to spot trouble and receiving contributed improvements makes it for a better package in the end. L. > -- Nathaniel ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ rpy-list mailing list rpy-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rpy-list
