Eliminates the remaining warnings when compiling with something like "-O2 
-flto=auto" as CXXFLAGS.

This is not pretty C++, just seems the least disruptive way to remove the 
violation in time for the alpha. The rpmdb layer needs a much bigger overhaul 
to make it resemble something like C++

Technically bdb_ro.cc didn't require this as it was using explicit C-style 
casts to its own cursor struct, but might as well change update it as well.

No intended functional changes in any of this, and the test-suite passes with 
both sqlite and ndb (latter tested locally).

Fixes: #3692
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3695

-- Commit Summary --

  * Fix some tests assuming that sqlite rpmdb is the default
  * Minimally fix C++ one definition rule violation in the rpmdb backends

-- File Changes --

    M lib/backend/bdb_ro.cc (18)
    M lib/backend/dbi.hh (3)
    M lib/backend/ndb/glue.cc (51)
    M lib/backend/sqlite.cc (76)
    M tests/rpmdb.at (7)
    M tests/rpmsigdig.at (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3695.patch
https://github.com/rpm-software-management/rpm/pull/3695.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3695
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to