@dmnks commented on this pull request.


>  
-    if (skipSoname(soname))
+static void addSoDep(std::vector<std::string> & deps,
+                    const std::string & soname,
+                    const std::string & ver, const std::string & marker)
+{
+    if (skipSoname(soname.c_str()))

Oh, now I somewhat recall that you can actually assign a C string to an 
`std::string` variable. Still, it seems like the conversion can be removed for 
clarity anyway. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3581#discussion_r1968083141
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3581/review/2637886...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to