@pmatilai commented on this pull request.


> @@ -227,6 +236,10 @@ static int addTE(rpmte p, Header h, fnpyKey key, 
> rpmRelocation * relocs)
     rc = 0;
 
 exit:
+    if (rc) {
+       rpmlog(RPMLOG_ERR, _("misformed package %s\n"),
+              p->NEVRA ? p->NEVRA : (p->name ? p->name : "-"));
+    }

So ... I think we're better off just not logging this at all. The caller gets 
an error code 1, if they don't report it than that's their problem, not ours.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3478#discussion_r1867184533
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3478/review/2474794...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to