It's not any less code, but gives us much better control over how 
they're called, eliminating the need for global temporary macros for 
passing what really are command arguments.

No functional change, but paves way for future programmatic switches such as 
perhaps binary/ascii signatures.

This is of course incompatible with folks who have their own custom 
%__gpg_sign_cmd from the past, recipes for these have unfortunately commonly 
floated around the internet as "necessary" for signing. These are 
double-underscore macros, people messing with those had better know what 
they're doing.


You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3476

-- Commit Summary --

  * Sanitize %__foo_sign_cmd macros
  * Make the signing macros parametric

-- File Changes --

    M macros.in (17)
    M sign/rpmgensig.cc (18)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3476.patch
https://github.com/rpm-software-management/rpm/pull/3476.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3476
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to