@pmatilai commented on this pull request.


>  {
     rpmRC rc = RPMRC_OK;
     ARGV_t files = NULL;
     int nfiles = 0;
     char *dsoPath = NULL;
 
+    /* Source packages aren't really installed, only unpacked */
+    if (headerIsSource(h))

This will break things if you do 'rpm -Uvh foo.src.rpm bar.noarch.rpm', which 
doesn't make much sense but is something that the cli supports anyhow. It 
should be easy to disable plugins on per-package basis in 
rpmPackageFilesInstall() and rpmPackageFilesRemove() - just use NULL for 
plugins instead of rpmtsPlugins() if the rpmte is a source rpm.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3470#pullrequestreview-2461531302
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3470/review/2461531...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to