@pmatilai commented on this pull request.
> sqlexec(sdb, "PRAGMA optimize");
sqlexec(sdb, "PRAGMA wal_checkpoint = TRUNCATE");
+
+ int max_size = rpmExpandNumeric("%{?_sqlite_vacuum_kb}");
+ if (max_size <= 0)
+ max_size = 20*1024;
+ int64_t free_space = sqlite_free_space(sdb) >> 10;
int64_t here doesn't help when it's long in sqlite_free_space(). Which should
return the same kind of data as the macro really so this calculation belongs to
that function, more like. Doing *1024 but then >> 10 looks super confusing,
lets just stick to basic maths for doing math, because to me a bitshift
suggests there's something more special going on.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3452#pullrequestreview-2445242204
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3452/review/2445242...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
https://lists.rpm.org/mailman/listinfo/rpm-maint
