@pmatilai commented on this pull request.
>
- if (replace) {
- rasprintf(&tmppath, "%s.new", path);
- unlink(tmppath);
+ rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags);
+
+ if (!rc && replace) {
+ /* find and delete the old pubkey entry */
Split any fs::keystore refactor into a separate commit. It wont help the GH
review but it'll at least make it 10x more obvious when looking at it on the
commit level. Patch readability is an important factor too.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3437#discussion_r1836112998
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3437/review/2426367...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
