@pmatilai commented on this pull request.
> @@ -22,6 +23,7 @@ struct rpmlogCtx_s {
unsigned mask;
int nrecsPri[RPMLOG_NPRIS];
std::vector<rpmlogRec_s> recs;
+ std::map<uint64_t, std::map<std::pair<int, std::string>, int>> seen;
Oh, interesting. It didn't really even occur to me that you'd need to define a
hash for it when map didn't require any custom comparison stuff for this
structure. That's something to keep in mind.
Water gets deep very suddenly in C++ - on one line you're operating on
ridiculously high level and on the next one you run into an absurdly long
compiler error because you failed to define some low-level detail you'd kinda
expect the compiler to do for you because this is all standard datatypes.
Python it is not :sweat_smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3417#discussion_r1827359674
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3417/review/2412448...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
