> The macro class needs a bit more doc strings.
I don't disagree, but we don't traditionally have much in the way of docs for
internal APIs. What do you want to see documented, the locking scheme?
> It is kinda weird that it is basically just a lock around the macro context.
> Not that there is anything wrong with that - it's just weird
This is basically how you want a locked resource to be handled in C++. It's a
different paradigm from what we've had, sure. The various fooAcquire() things
were a kind of emulation of this though.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3408#issuecomment-2447073575
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3408/c2447073...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint