@pmatilai commented on this pull request.
> rpmPubkeyFree(item->second);
keyring->keys.erase(item);
rc = 0;
- } else if (item != range.second && mode == RPMKEYRING_REPLACE) {
- rpmPubkeyFree(item->second);
- item->second = rpmPubkeyLink(key);
- rc = 0;
- } else if (item == range.second && (mode == RPMKEYRING_ADD || mode ==
RPMKEYRING_REPLACE) ) {
+ } else if ((item == range.second && mode == RPMKEYRING_ADD) || mode ==
RPMKEYRING_REPLACE) {
+ int subkeysCount = 0;
+ rpmPubkey *subkeys = rpmGetSubkeys(key, &subkeysCount);
This isn't a requirement, just noting that going forward we'll want to change
the subkey fetch to an internal C++ native version with rpmGetSubkeys()
becoming just a deprecated wrapper around it.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3403#pullrequestreview-2392443331
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3403/review/2392443...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
