Details in commit messages, but short summary is that this is all just refactoring prep-work for #3342. The added API of keystore Load, Import and Delete functions sort of achieves the abstraction but this exact API shouldn't be seen as any final state of affairs, it's just a milestone along the road.
This looks big but the actual code changes are rather minimal, on purpose. Once this lands, the next steps will be isolating the header fubar into the rpmdb keystore and making the keystore an actual type (think object) instead of just being ifs around keyringtype number. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3397 -- Commit Summary -- * Add some internal APIs around rpmtxn, use in keystore operations * Rename keystore load functions to rpmts prefix * Drop unused subkey arguments to makePubkeyHeader() * Refactor the keystore level import to a helper function * Add + use pubkey based keystore delete functions * Refactor lower level keystore delete to separate function * Refactor lower level keystore load to separate function * Split keystore handling to a separate source -- File Changes -- M lib/CMakeLists.txt (1) A lib/keystore.cc (471) A lib/keystore.hh (15) M lib/rpmts.cc (457) M lib/rpmts_internal.hh (5) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3397.patch https://github.com/rpm-software-management/rpm/pull/3397.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3397 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/3...@github.com>
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
