@pmatilai commented on this pull request.


> @@ -1371,3 +1371,21 @@ runroot rpm -q --whatprovides /
 ],
 [])
 AT_CLEANUP
+
+AT_SETUP([rpm -U with Obsoletes])
+AT_KEYWORDS([install])
+AT_CHECK([
+RPMDB_INIT
+
+runroot rpmbuild -bb --quiet /data/SPECS/test-obsoletes.spec
+runroot rpm -i --nodeps --ignorearch /data/RPMS/hello-1.0-1.i386.rpm
+runroot rpm -U /build/RPMS/noarch/test-obsoletes-1.0-1.noarch.rpm

Heh, good spotting that we seem to have no test for the plain vanilla 
package-obsoletes-another case.

But do use the existing test material, you can just build another variant at 
the start of the "rpm -U obsoleted packages" test and the test against it in 
its own AT_CHECK group just like the other obsoletes-tests. That also avoids 
the problematic hello package which should only be used for special cases.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2254#pullrequestreview-1171693141
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2254/review/1171693...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to